-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix contributing links #155
Conversation
…e it with repo-issues in point 2
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/organization-genomics/compare/md-outputs..md-outputs-PR-155 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-06-05 16:56:16 +0000 |
If @zkamvar approves the "issues list" change and can point me to a list of repos that have been converted to Workbench, I am happy to create similar PRs for those repos in addition to the template repo. |
HI @JCSzamosi, thank you so much! I agree that the "issues list" phrasing is a very sensible change. You can find a list of repositories that have been transitioned in https://carpentries.github.io/workbench/transition-schedule.html They are also listed as issue titles in the lesson transition repository, so you can use the GitHub API to retrieve a machine-readable list:
|
Thank you @zkamvar! I know best practice says PRs should not be proposed and approved by the same maintainer, so I'm going to give it a couple days for another @datacarpentry/organization-genomics-maintainers maintainer to merge this. In the mean time, I will create PRs for the template repo and existing, transitioned repos |
Thanks for being on top of this @JCSzamosi |
Since no one has objected in the past several days, I'm going to merge this now. |
Auto-generated via {sandpaper} Source : 960d7a3 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2023-06-12 20:50:37 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 77cf0f8 Branch : main Author : JCSzamosi <4465403+JCSzamosi@users.noreply.github.com> Time : 2023-06-12 20:48:57 +0000 Message : Merge pull request #155 from datacarpentry/fix_contributing_links Fix contributing links
Auto-generated via {sandpaper} Source : 960d7a3 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2023-06-12 20:50:37 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 77cf0f8 Branch : main Author : JCSzamosi <4465403+JCSzamosi@users.noreply.github.com> Time : 2023-06-12 20:48:57 +0000 Message : Merge pull request #155 from datacarpentry/fix_contributing_links Fix contributing links
Addressing the broken links raised by @tobyhodges in #154.
This also makes the change to the "issues" list discussed in that same thread. I'm requesting @zkamvar review it before I make a similar PR to the template repo so that I only have to make changes in one place.
fixes #154