Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributing links #155

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Fix contributing links #155

merged 2 commits into from
Jun 12, 2023

Conversation

JCSzamosi
Copy link
Contributor

Addressing the broken links raised by @tobyhodges in #154.

This also makes the change to the "issues" list discussed in that same thread. I'm requesting @zkamvar review it before I make a similar PR to the template repo so that I only have to make changes in one place.

fixes #154

@JCSzamosi JCSzamosi requested a review from zkamvar June 5, 2023 16:54
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/organization-genomics/compare/md-outputs..md-outputs-PR-155

The following changes were observed in the rendered markdown documents:


What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-06-05 16:56:16 +0000

github-actions bot pushed a commit that referenced this pull request Jun 5, 2023
@JCSzamosi
Copy link
Contributor Author

If @zkamvar approves the "issues list" change and can point me to a list of repos that have been converted to Workbench, I am happy to create similar PRs for those repos in addition to the template repo.

@zkamvar
Copy link
Contributor

zkamvar commented Jun 6, 2023

HI @JCSzamosi, thank you so much! I agree that the "issues list" phrasing is a very sensible change.

You can find a list of repositories that have been transitioned in https://carpentries.github.io/workbench/transition-schedule.html

They are also listed as issue titles in the lesson transition repository, so you can use the GitHub API to retrieve a machine-readable list:

GET /repos/carpentries/lesson-transition/issues?status=closed&label=lesson

@JCSzamosi
Copy link
Contributor Author

Thank you @zkamvar!

I know best practice says PRs should not be proposed and approved by the same maintainer, so I'm going to give it a couple days for another @datacarpentry/organization-genomics-maintainers maintainer to merge this.

In the mean time, I will create PRs for the template repo and existing, transitioned repos

@hidyverse
Copy link
Contributor

Thanks for being on top of this @JCSzamosi

@JCSzamosi
Copy link
Contributor Author

Since no one has objected in the past several days, I'm going to merge this now.

@JCSzamosi JCSzamosi merged commit 77cf0f8 into main Jun 12, 2023
@JCSzamosi JCSzamosi deleted the fix_contributing_links branch June 12, 2023 20:48
github-actions bot pushed a commit that referenced this pull request Jun 12, 2023
Auto-generated via {sandpaper}
Source  : 77cf0f8
Branch  : main
Author  : JCSzamosi <4465403+JCSzamosi@users.noreply.github.com>
Time    : 2023-06-12 20:48:57 +0000
Message : Merge pull request #155 from datacarpentry/fix_contributing_links

Fix contributing links
github-actions bot pushed a commit that referenced this pull request Jun 12, 2023
Auto-generated via {sandpaper}
Source  : 960d7a3
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-06-12 20:50:37 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 77cf0f8
Branch  : main
Author  : JCSzamosi <4465403+JCSzamosi@users.noreply.github.com>
Time    : 2023-06-12 20:48:57 +0000
Message : Merge pull request #155 from datacarpentry/fix_contributing_links

Fix contributing links
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
Auto-generated via {sandpaper}
Source  : 960d7a3
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-06-12 20:50:37 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 77cf0f8
Branch  : main
Author  : JCSzamosi <4465403+JCSzamosi@users.noreply.github.com>
Time    : 2023-06-12 20:48:57 +0000
Message : Merge pull request #155 from datacarpentry/fix_contributing_links

Fix contributing links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links need to be fixed in CONTRIBUTING.md
3 participants